[PATCH] nvme: Quirks for PM1725 controllers

Martin K. Petersen martin.petersen at oracle.com
Wed Jun 28 09:51:51 PDT 2017


Keith,

>> and the this is:
>> 
>> 	} else if (dev->ctrl.quirks & NVME_QUIRK_QD_LIMIT_64) {
>> 
>> While its inside the pci driver, I think it would be cleaner to
>> use the quirks mechanism.
>> 
>> Kieth? thoughts?
>
> Yeah, that's better than VID:DID checks. We only get 32 defined quirks
> using driver_data, and while we currently can spare 2 of them for q-depth
> quirks, I was hoping to use these bits more sparingly.

That's fine. I did tinker with quirks for the queue depth at some point
but I think I had problems due to needing to clamp the admin queue depth
as well. I had to shuffle a bunch of stuff and introduce wrappers for
accessing the AQ depth. But with Sagi's recent patch that's no longer
necessary. So most of that churn went away when I rebased yesterday.

Will resend.

-- 
Martin K. Petersen	Oracle Linux Engineering



More information about the Linux-nvme mailing list