[PATCH 3/3] nvme-pci: open-code polling logic in nvme_poll

Christoph Hellwig hch at lst.de
Sun Jun 18 06:12:30 PDT 2017


On Sun, Jun 18, 2017 at 12:29:33PM +0300, Sagi Grimberg wrote:
>
>>>   static int __nvme_poll(struct nvme_queue *nvmeq, unsigned int tag)
>>>   {
>>> +	struct nvme_completion cqe;
>>> +	int found = 0, consumed = 0;
>>
>> found should be a bool.
>
> I'm returning found back from ->poll() callout so
> I think I'll keep it int, unless you want me to modify
> poll_fn signature?

Let's keep it as-is for now.



More information about the Linux-nvme mailing list