[PATCH] nvme: don't hard code size of struct t10_pi_tuple

Christoph Hellwig hch at lst.de
Thu Jun 15 23:28:40 PDT 2017


On Thu, Jun 15, 2017 at 04:29:18PM +0300, Sagi Grimberg wrote:
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> ---
>  drivers/nvme/host/core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index a5b7926cf7f6..761ca3e6ee2e 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -336,7 +336,8 @@ static inline blk_status_t nvme_setup_rw(struct nvme_ns *ns,
>  	 * unless this namespace is formated such that the metadata can be
>  	 * stripped/generated by the controller with PRACT=1.
>  	 */
> -	if (ns && ns->ms && (!ns->pi_type || ns->ms != 8) &&
> +	if (ns && ns->ms &&
> +	    (!ns->pi_type) || ns->ms != sizeof(struct t10_pi_tuple)) &&

This actually got the braces wrong, I'll fix it up.



More information about the Linux-nvme mailing list