[PATCH] nvme-rdma: "nvme disconnect" stuck after remove a target

Sagi Grimberg sagi at grimberg.me
Sun Jul 30 23:47:31 PDT 2017


> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 3d25add..44316bc 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -1637,7 +1637,7 @@ static void nvme_rdma_shutdown_ctrl(struct nvme_rdma_ctrl *ctrl)
>                  nvme_rdma_free_io_queues(ctrl);
>          }
> 
> -       if (test_bit(NVME_RDMA_Q_CONNECTED, &ctrl->queues[0].flags))
> +       if (test_bit(NVME_RDMA_Q_LIVE, &ctrl->queues[0].flags))
>                  nvme_shutdown_ctrl(&ctrl->ctrl);
> 
>          blk_mq_stop_hw_queues(ctrl->ctrl.admin_q);

I think you are not testing upstream code which already contain this
change from:

commit b282a88d910296facf89fd1088832f9b41fa00c5
Author: Sagi Grimberg <sagi at grimberg.me>
Date:   Thu May 4 13:33:11 2017 +0300

     nvme-rdma: Get rid of CONNECTED state

     We only care about if the queue is LIVE for request submission,
     so no need for CONNECTED.

     Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
     Signed-off-by: Christoph Hellwig <hch at lst.de>



More information about the Linux-nvme mailing list