[PATCH v3] nvme: Add support for NVMe 1.3 Timestamp Feature

Christoph Hellwig hch at lst.de
Fri Jul 14 00:12:11 PDT 2017


> +	status = nvme_set_features(ctrl, NVME_FEAT_TIMESTAMP,
> +				   0, &ts, sizeof(ts), NULL);
> +	if (status != 0)

If I'd want to nitpick, I'd say move as many as possible arguments to
the first line, and remove the superflous "!= 0":

	status = nvme_set_features(ctrl, NVME_FEAT_TIMESTAMP, 0, &ts,
				   sizeof(ts), NULL);
	if (status)

but that's something we can fix up when applying the patch.

Looks fine:

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the Linux-nvme mailing list