[PATCH 2/7] nvme/fc: Fix admin queue depth setup

Keith Busch keith.busch at intel.com
Mon Jul 10 15:57:30 PDT 2017


On Mon, Jul 10, 2017 at 08:59:02AM +0300, Sagi Grimberg wrote:
> > The NVME_FC_AQ_BLKMQ_DEPTH is one less than what we actually want the
> > admin queue's depth to be since it subtracts the AEN entry.
> > 
> > We also need to subtract 1 from the blk-mq depth to always leave an
> > empty queue entry, and to not collide command id with the AEN request.
> > 
> > Signed-off-by: Keith Busch <keith.busch at intel.com>
> 
> nvme-loop needs the same patch.

Yeah, it looks like it does, though it's inadvertently fixed in patch
4. In truth, patch 4 makes this one unnecessary for fc too, but I didn't
want to change the q-depth and centralize its definition in a single
patch. I'll spin a new version with the loop fix in the series, as well
as Christoph's suggestions.



More information about the Linux-nvme mailing list