[PATCH v2 1/8] nvme-rdma: quiesce/unquiesce admin_q instead of start/stop its hw queues

Ming Lei ming.lei at redhat.com
Wed Jul 5 00:34:24 PDT 2017


On Wed, Jul 05, 2017 at 10:15:28AM +0300, Sagi Grimberg wrote:
> 
> > As I commented yesterday, blk_mq_kick_requeue_list() isn't needed.
> 
> I commented in the cover-letter, I am removing it a two steps to keep
> bisection. I'm only allowed to remove it in patch 5/8.

The kick requeue list shouldn't be added at the 1st step.

The thing is simple, we only need to kick request list where the queue
is restarted. Now quiesce and unquiesce do not touch STOP state, so
it may make people confused if you add the kick after unquiese.

-- 
Ming



More information about the Linux-nvme mailing list