[PATCHv3] nvmet-rdma: Fix missing dma sync to nvme data structures

[Parav Pandit]

Hi Christoph,

> -----Original Message-----
> From: Christoph Hellwig [mailto:hch at lst.de]
> Sent: Thursday, January 19, 2017 9:23 AM
> To: Parav Pandit <parav at mellanox.com>
> Cc: hch at lst.de; sagi at grimberg.me; linux-nvme at lists.infradead.org; linux-
> rdma at vger.kernel.org; dledford at redhat.com
> Subject: Re: [PATCHv3] nvmet-rdma: Fix missing dma sync to nvme data
> structures
> 
> >
> > +	ib_dma_sync_single_for_cpu(queue->dev->device,
> > +		cmd->cmd->sge[0].addr, cmd->cmd->sge[0].length,
> > +		DMA_FROM_DEVICE);
> > +	ib_dma_sync_single_for_cpu(queue->dev->device,
> > +			cmd->send_sge.addr, cmd->send_sge.length,
> > +			DMA_TO_DEVICE);
> 
> Why the different indentation here?  Both one or two tab indents look fine to
> me in this context, but don't mix them.
> 
I agree. I should have taken care of that.
Shall I resend patch with same indentation at all places or this can be taken care during commit?

> Except for that this looks fine:
> 
> Reviewed-by: Christoph Hellwig <hch at lst.de>