[PATCH v4 2/6] block: Add Sed-opal library

J Freyensee james_p_freyensee at linux.intel.com
Wed Jan 11 09:47:14 PST 2017


[Snip...]


> > 
> > +	if(!suspend)
> 
> missing whitespace before the (
> 
> > 
> > +	list_for_each_entry(suspend, &dev->unlk_lst, node) {
> > +			dev->state = 0;
> > +			dev->func_data[1] = &suspend->unlk.session;
> 
> doube indentation.
> 

Is checkpatch.pl being used before the patches are sent to the list?  That tool
should have flagged these problems to fix.

While you are at it, it would be good to run the code thru sparse if you
haven't already.

Jay

>


More information about the Linux-nvme mailing list