[PATCH v4 4/6] block: Add Opal Files to Makefile & add config option to Kconfig

Christoph Hellwig hch at infradead.org
Sun Jan 8 06:09:11 PST 2017


> +config BLK_SED_OPAL
> +        bool "Library for interfacing with Opal enabled SEDs"
> +	default n
> +	---help---
> +	Builds library for interfacing with Opal enabled controllers.
> +

Inconsistant whitespaces here, kust use tabs.  The defauly n is the
defaul, so it could be dropped.  Maybe the help text could be expanded
a bit, including explining what SED stands for (I know, but many
potential users don't), and de-emphasis the library part.

E.g. something like

config BLK_SED_OPAL
	bool "Support for OPAL Self Encrypting Drives"
	help
	  This optional enables support for Self Encrypting Drives
	  using the TCG OPAL protocol family.




More information about the Linux-nvme mailing list