[PATCH] nvme: use __iowrite64_copy for SQs in the CMB

Christoph Hellwig hch at infradead.org
Sun Jan 8 02:13:28 PST 2017


On Wed, Jan 04, 2017 at 09:22:34AM +0200, Saar Gross wrote:
> As already mentioned: the current implementation uses memcpy() which
> is generic in nature, whereas the new implementation uses explicit
> 64-bit writes when possible.
> What else are you looking for?

Any explanation of why this would benefit the driver in practive.
You've now explained the mechanics of your change in detail, but still
haven't shown in numbers or bugs fixed.

Note that we currently don't use 64-bit MMIO writes in the NVMe driver
at all, as we work around buggy Apple controllers.  This would be the
first one, and while I'm not against it at all, I'd rather have a good
reason to make the change instead of just having a drive-by patch in
the tree.



More information about the Linux-nvme mailing list