[PATCH] NVMe: Format fix when going from 4k sector size to 512 bytes

Christoph Hellwig hch at infradead.org
Fri Dec 15 06:53:23 PST 2017


On Thu, Dec 14, 2017 at 10:52:11PM -0500, Martin K. Petersen wrote:
> 
> Jeff,
> 
> > +	blk_queue_logical_block_size(disk->queue, bs);
> > +	blk_queue_physical_block_size(ns->queue, bs);
> 
> A bit messy that you mix ns->queue and disk->queue.

It's not just ugly, but actually broken.  We must use disk->queue
both times to correctly handle multipathing.



More information about the Linux-nvme mailing list