[PATCHv2] nvme/fc: add 'discovery' sysfs attribute to fc transport device

Hannes Reinecke hare at suse.de
Sun Dec 3 23:18:19 PST 2017


On 12/01/2017 05:21 PM, James Smart wrote:
> On 12/1/2017 1:27 AM, Hannes Reinecke wrote:
>> +    spin_lock_irqsave(&nvme_fc_lock, flags);
>> +    list_for_each_entry(lport, &nvme_fc_lport_list, port_list) {
>> +        list_for_each_entry(rport, &lport->endp_list, endp_list) {
>> +            if (!nvme_fc_lport_get(lport))
>> +                continue;
>> +            if (!nvme_fc_rport_get(rport))
>> +                continue;
> 
> ref counting messed up if rport_get fails - need to back out the lport get.
> 
Bah. Correct.

Will be sending a new version.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)



More information about the Linux-nvme mailing list