[PATCH 2/3] nvme: introduce max_segments controller attribute

Sagi Grimberg sagi at grimberg.me
Wed Aug 16 12:04:09 PDT 2017


>> Why is this needed with patches 1,3 applied?
>>
>> We set the page_size and we set max_hw_sectors accordingly.
> 
> We didn't touch the ctrl->page_size. It's always 4k (the target checks it).
> This may cause max_segments to be bigger than hw limitation (in PPC for 
> example).

Right, got confused for a second, but why shouldn't we modify the
ctrl page_size in rdma? Its not really a controller attribute, but
rather the local HCA attribute really.

Or, we could simply fix nvme-core to take PAGE_SIZE if supported by
the ctrl and fallback to 4k otherwise.



More information about the Linux-nvme mailing list