[PATCH v2] nvmet core: skip flags checks on fabric commands

Christoph Hellwig hch at infradead.org
Fri Apr 28 07:28:12 PDT 2017


On Thu, Apr 27, 2017 at 08:04:14PM -0700, jsmart2021 at gmail.com wrote:
> From: James Smart <jsmart2021 at gmail.com>
> 
> The core layer validates nvme command flags (w0 byte 1) values before
> decoding opcodes. On fabric commands the flags field is reserved.
> Current validations require NVME_CMD_SGL_METABUF or NVME_CMD_SGL_METASEG
> to be set. If host sets flags to 0 as reserved field, command fails.
> 
> Exclude fabric commands from flags checks.

Eww.  I'd rather talk to the working group and get this fixed in an
errata.  Treating a field special for fabrics command does not make
sense.



More information about the Linux-nvme mailing list