[PATCH 2/7] nvme/fc: don't byte swap command_id

[James Smart]

On 4/21/2017 1:50 AM, Christoph Hellwig wrote:
> The command ID is a field for host only use and thus always is in
> native endian.
>
> Found by sparse.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> ---
>   drivers/nvme/host/fc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
> index 63819b12c1da..68887818801e 100644
> --- a/drivers/nvme/host/fc.c
> +++ b/drivers/nvme/host/fc.c
> @@ -1274,7 +1274,7 @@ nvme_fc_fcpio_done(struct nvmefc_fcp_req *req)
>   			     be32_to_cpu(op->rsp_iu.xfrd_len) !=
>   					freq->transferred_length ||
>   			     op->rsp_iu.status_code ||
> -			     op->rqno != le16_to_cpu(cqe->command_id))) {
> +			     op->rqno != cqe->command_id)) {
>   			status = cpu_to_le16(NVME_SC_FC_TRANSPORT_ERROR << 1);
>   			goto done;
>   		}

This check was replaced in the following patch, obsoleting this change:
http://lists.infradead.org/pipermail/linux-nvme/2017-April/009259.html


> @@ -1830,7 +1830,7 @@ nvme_fc_start_fcp_op(struct nvme_fc_ctrl *ctrl, struct nvme_fc_queue *queue,
>   	sqe->rw.dptr.sgl.addr = 0;
>   
>   	/* odd that we set the command_id - should come from nvme-fabrics */
> -	WARN_ON_ONCE(sqe->common.command_id != cpu_to_le16(op->rqno));
> +	WARN_ON_ONCE(sqe->common.command_id != op->rqno);
>   
>   	if (op->rq) {				/* skipped on aens */
>   		ret = nvme_fc_map_data(ctrl, op->rq, op);

This line was removed by the following patch, obsoleting this change:
http://lists.infradead.org/pipermail/linux-nvme/2017-April/009260.html

-- james