[PATCH] nvme/pci: Poll CQ on timeout

Keith Busch keith.busch at intel.com
Thu Apr 20 07:20:44 PDT 2017


On Thu, Apr 20, 2017 at 10:56:09AM +0200, Johannes Thumshirn wrote:
> On Tue, Feb 28, 2017 at 10:44:21AM -0700, Jens Axboe wrote:
> > IMHO that can go at a later time, if we do remove polling for
> > specific entries. For now it's fine.
> > 
> > And I do think this is a nice addition - it's free, and it provides
> > us extra info for debugging an issue. That's a big deal, especially
> > if it's a user report.
> 
> JFYI, we did have I/O timeout issues on one of our internal systems.
> Keith suggested to give this patch a shot and indeed it cought missed IRQs,
> which after being polled at least didn't result in filesystem errors.
> 
> So if you want you can have my:
> Tested-by: Johannes Thumshirn <jthumshirn at suse.de>
> Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>

Thanks, I forgot about this one, but still think it's a good idea.
Applied it to for-next.



More information about the Linux-nvme mailing list