[PATCH v2] nvme_fc: avoid double kfree(), don't call nvme_cleanup_cmd() in nvme_fc_unmap_data()

Johannes Thumshirn jthumshirn at suse.de
Thu Apr 6 11:17:43 PDT 2017


On Thu, Apr 06, 2017 at 12:47:56PM -0400, Ewan Milne wrote:
> nvme_cleanup_cmd() is already called by callers of nvme_fc_unmap_data().
> Don't call it twice to avoid double-free on completion of discard commands.
> 
> v2:
> Move nvme_cleanup_cmd() call *after* nvme_fc_unmap_data() for consistency.
> 
> Signed-off-by: Ewan D. Milne <emilne at redhat.com>
> ---

Thanks,
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850



More information about the Linux-nvme mailing list