[PATCH] nvme_fc: avoid double kfree(), don't call nvme_cleanup_cmd() in nvme_unmap_data()
Johannes Thumshirn
jthumshirn at suse.de
Thu Apr 6 07:53:40 PDT 2017
Hi Ewan,
On Thu, Apr 06, 2017 at 10:16:30AM -0400, Ewan Milne wrote:
> nvme_cleanup_cmd() is already called by callers of nvme_unmap_data().
nvme_fc_unmap_data()? ^
And besides this, in nvme_fc_complete_rq() it is called before
nvme_fc_unmap_data() in nvme_fc_start_fcp_op() afterwards. Even if this is a
correct behaviour (i.e. doesn't harm as we're not touching
req->special_vec.bv_page in nvme_fc_unmap_data() it at a first sight looks
like an error. Care to adjust it?
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
More information about the Linux-nvme
mailing list