[PATCH] nvme-rdma: Fix early queue flags settings

Steve Wise swise at opengridcomputing.com
Wed Sep 21 07:52:37 PDT 2016


> Sagi, you originally proposed this in a patch for debugging the crash
where
> a request is accessing a queue with rdma resources freed:
> 
> @@ -542,11 +542,12 @@ static int nvme_rdma_create_queue_ib(struct
> nvme_rdma_queue *queue,
>                  goto out_destroy_qp;
>          }
>          set_bit(NVME_RDMA_IB_QUEUE_ALLOCATED, &queue->flags);
> +       clear_bit(NVME_RDMA_Q_DELETING, &queue->flags);
> 
>          return 0;
> 
> 
> Perhaps this is how we should proceed?

Just tested this, and it doesn't fix the problem.  This makes sense, because
we really only want to clear it if we successfully setup the connection...
So never mind. :)  




More information about the Linux-nvme mailing list