[PATCH] nvme-rdma: Fix early queue flags settings

Steve Wise swise at opengridcomputing.com
Tue Sep 20 13:14:15 PDT 2016


> 
> On Tue, Sep 20, 2016 at 11:57:28AM -0700, Sagi Grimberg wrote:
> > When we reconnect we can't really clear the
> > queue flags (DELETING flag in specific) because
> > we might end up trigerring a use-after-free condition
> > if we fail to establish the rdma connection.
> 
> Can you add a comment explaining this to the assignment?  Looking
> at the patch it looks like black magic to be, and that's even
> after reading the above changelog..

Maybe this changelog?

    nvme-rdma: only clear queue flags after successful connect

    Otherwise, nvme_rdma_stop_and_clear_queue() will incorrectly
    try to stop/free rdma qps/cm_ids that are already freed.




More information about the Linux-nvme mailing list