[PATCH] admin-cmd: Added smart-log command support.

Sagi Grimberg sagi at grimberg.me
Mon Sep 5 07:09:15 PDT 2016


>> Given that we don't own the namespaces, I'm wandering if this is the
>> correct way to do this... I'm not at all convinced that having something
>> else reading/writing to the blkdevs other than nvmf is a valid/useful
>> use-case but in this situation we won't get correct log information
>> (or at least the semantics is wrong).
>>
>> Should we maintain these statistics in the target stack instead?
>
> What's the problem with including possible local I/O?  Having to
> maintain another set of counters, including atomics in the fast path
> or complex per-cpu infrastructure is something I'd rather avoid.

I don't want it either. But I think that the semantics of the
smart log info is different, the question is are we ok with it?



More information about the Linux-nvme mailing list