[PATCH 1/2] nvme: introduce struct nvme_request

Christoph Hellwig hch at lst.de
Thu Oct 27 00:16:00 PDT 2016


On Wed, Oct 26, 2016 at 12:11:54PM -0700, James Smart wrote:
> Ok - I understand. nevermind. Patch description covered it.
>
> Can't say I agree with these kind of subtle coding requirements between 
> layers. As soon as the patch description is gone, the understanding of the 
> requirement gets lost without deep understanding of the code.

It's not really any different from the current passthrough code,
which casts two unrelated field in struct request to NVMe data structures.
I'll have to see if I could come up with some BUILD_BUG_ON magic, but
in the this is how we do poor man's inheritance.



More information about the Linux-nvme mailing list