[PATCH v3 4/6] nvme-rdma: use rdma connection reject helper functions

Sagi Grimberg sagi at grimberg.me
Tue Oct 25 10:04:50 PDT 2016

> On Tue, Oct 25, 2016 at 07:36:25PM +0300, Sagi Grimberg wrote:
>> I think it'd be better to move them to include/linux/nvme-rdma.h
>> and use them for logging on the target side too.
> Hmm, that would mean they get compiled into every source file.

"every source file" is exactly two...

> Also on the target side we can have free-form messages for whatever
> the exact rejection reason was, no need to limit us to the enum.

Thought it'd be nice to use the same verbosity on both ends, just a
suggestion though...

More information about the Linux-nvme mailing list