[PATCH RFC v2 0/3] connect reject event helpers

[Chuck Lever]

> On Oct 24, 2016, at 1:44 PM, Steve Wise <swise at opengridcomputing.com> wrote:
> 
>>> 
>>>> While reviewing:
>>>> 
>>>> 
>> http://lists.infradead.org/pipermail/linux-nvme/2016-October/006681.html
>>>> 
>>>> I decided to propose transport-agnostic helper functions to better
>>>> handle connection reject event information.  I've included a nvme_rdma
>>>> patch to utilize the new helpers.
>>>> 
>>>> Thoughts?
>>> 
>>> Hey Steve,
>>> 
>>> This looks nice and useful. Would be great if you can
>>> also help other ULPs that use this (e.g. srp/srpt)
>> 
>> can-do!
> 
> Actually, srp uses the ib_cm directly.  Further it already has logic to do
> various actions based on the IB_CM Reject status.  It really doesn't need these
> helpers.  The only one would be ibcm_reject_msg().  Looking at the iser
> initiator, it logs nothing on a reject event. And nfsrdma doesn't log any
> details about the reject reason also.  
> 
> I could add a dev_warn() or something for iser and nfsrdma.

I'm fixing an issue in this area. I'd like to take care of
the xprtrdma connection upcall myself once you've got these
new APIs introduced.


--
Chuck Lever