[PATCH RFC v2 3/3] nvme-rdma: use rdma_reject_msg() to log connection rejects
sagi at grimberg.me
Fri Oct 21 14:48:06 PDT 2016
> Given the nasty casting issues in the current RDMA/CM API maybe we should
> actually expand the scope of the rdma_consumer_reject helper to include
> the above check, e.g. check that there is a private data len and then
> return a pointer to the private data?
> Something like
> static int nvme_rdma_conn_rejected(struct nvme_rdma_queue *queue,
> struct rdma_cm_event *ev)
> struct rdma_cm_id *cm_id = queue->cm_id;
> struct nvme_rdma_cm_rej *rej
> short nvme_status = -1;
> rej = rdma_cm_reject_message(ev);
> if (rej)
> nvme_status = le16_to_cpu(rej->sts);
>> + dev_err(queue->ctrl->ctrl.device, "Connect rejected: status %d (%s) "
>> + "nvme status %d.\n", rdma_status,
>> + rdma_reject_msg(cm_id, rdma_status), nvme_status);
> And while we're pretty printing the rest it would be nice to pretty
> print the NVMe status here as well.
Would be nice...
More information about the Linux-nvme