[PATCH 3/7 v2] nvme-fabrics: Add FC transport FC-NVME definitions

Christoph Hellwig hch at infradead.org
Wed Oct 19 05:52:57 PDT 2016

On Tue, Oct 18, 2016 at 05:32:24PM -0600, Jon Derrick wrote:
> > What is the rule for when it should be a macro vs an inline ?   It makes
> > sense to me to be an inline if you want to strongly check the type of an
> > argument, but something simple like this, it's not so clear.  If I didn't
> > have the "cpu_to_be32" part, I'd abandon the inline and the macro and code
> > it directly.
> In this case they will both provide the same error checking, due to
> cpu_to_be32 returning type __be32. The only difference is that one adds
> a macro and the other adds a function, and if we ever need to add some
> caveats to the logic it will be simpler with the function. That and the
> coding style dictates that all things being equal, we should still
> prefer inline. Those are my only rationales in this case.

I generally prefer to avoid macros that make grepping hard.  But
I don't want to bikeshed too much over this this - I'd prefer Jon's
variant, but I'm not going to NAK the series over this helper.

More information about the Linux-nvme mailing list