[PATCH 2/3] fine tune the nvme-discover manpage

J Freyensee james_p_freyensee at linux.intel.com
Thu Oct 13 09:43:17 PDT 2016


On Thu, 2016-10-13 at 12:26 +0200, Christoph Hellwig wrote:
> On Wed, Oct 12, 2016 at 10:18:05AM -0700, J Freyensee wrote:
> > 
> > > 
> > > -nvme-discover - Send Get Log Page request to Discovery
> > > Controller.
> > > +nvme-discover - Send Discovery requests to Fabrics Discovery
> > > Controllers.
> > 
> > I preferred mentioning "Get Log Page" because that is really what
> > is
> > happening and reflects the NVMe specification, which I was aiming
> > to
> > push the envelope a bit and help educate and accelerate the
> > learning
> > curve for people new to these features (map more accurately what is
> > being described here to the NVMe specification(s).
> 
> While Get Log Page is technicaly correct I don't really think it
> serves the user much - it's the way the discovery is implemented,
> the important part is that we perform discovery.

I think it does serve the user, it educates the user a bit faster on
the NVMe Specification and what is really happening without spending
the time sorting through the spec, important for things like debugging
and diagnosis if something wonky happens.





More information about the Linux-nvme mailing list