[PATCH 6/7 v2] nvme-fabrics: Add target FC transport support

James Smart james.smart at broadcom.com
Wed Oct 12 12:57:56 PDT 2016

On 10/12/2016 2:42 AM, Christoph Hellwig wrote:

>> +	/*
>> +	 * beware: nvmet layer hangs waiting for a completion if
>> +	 * connect command failed
>> +	 */
>> +	flush_workqueue(queue->work_q);
> Can you elaborate on what the issue?

large carry over from code that was used as reference, although I saw it 
happen (when connect capsule was merged with the transport connect 
message).  I'll eliminate it or bring it forward.

>> +	/*
>> +	 * TODO: handle fused cmds back-to-back
>> +	 */
> Do you also plan to implement fused command support in the core?

no. once again, there are FC-NVME requirements, which if linux nvmet 
isn't supporting I could ignore. And hoping anyone who modifies nvmet 
knows a transport has to change too.  At least there will be a comment 
there indicating why the functionality isn't present.

Ok on the other comments.

-- james

More information about the Linux-nvme mailing list