[PATCH 2/2] nvme: Delete created IO queues on reset

Keith Busch keith.busch at intel.com
Thu Oct 6 08:23:37 PDT 2016

On Thu, Oct 06, 2016 at 11:32:52AM +0200, Christoph Hellwig wrote:
> On Wed, Oct 05, 2016 at 04:32:46PM -0400, Keith Busch wrote:
> > Commit c21377f8 (Suspend all queues before deletion) decrements the
> > online queue count prior to our attempt to delete those IO queues, so
> > the driver ended up not having the controller delete any. This patch
> > uses the queue_count instead of online_queues.
> What if not all queues were online before?  Should we take a
> a snapshot of ->online_queues before suspending the queues and
> then use that later?

That sounds good. In the worst case, using queue_count may attempt to
delete a queue the adapter didn't create, which just returns an invalid
QID error, and everything continues as normal. But it's easily
avoidable, so I'll send a v2 of this one.

More information about the Linux-nvme mailing list