[PATCH 3/7] nvme-fabrics: Add FC transport LLDD api definitions

[Hannes Reinecke]

On 10/06/2016 01:25 AM, James Smart wrote:
>
>
> On 10/4/2016 12:36 AM, Hannes Reinecke wrote:
>> We really need to work on integration with the SCSI FC code.
>> But I'd rather see to get this in first.
>> So:
>>
>> Reviewed-by: Hannes Reinecke <hare at suse.com>
>>
>> Cheers,
>>
>> Hannes
>
> I would not hold this up based on merging the scsi fc transport with the
> nvme fc transport - for topology items.  We can do this eventually, and
> it'll really change how things are layered with scsi (flips the fc
> transport devices/objects closer to the root device than the scsi host),
> making it very different from other scsi transports as well. lots of
> code change, especially to LLDD's.  Not something done lightly.
>
In the light of your explanation of the previous patch I agree with you.
We should be looking into integration, but this should be done at a 
later step. Especially as nvmet has similar issues right now.
So I retract my objection.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare at suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)