[PATCH] nvme/pci: Don't free queues on error

Christoph Hellwig hch at lst.de
Wed Nov 16 09:08:55 PST 2016


On Tue, Nov 15, 2016 at 03:56:26PM -0500, Keith Busch wrote:
> The nvme_remove function tears down all allocated resources in the correct
> order, so no need to free queues on error during initialization. This
> fixes possible use-after-free errors when queues are still associated
> with a blk-mq hctx.
> 
> Reported-by: Scott Bauer <scott.bauer at intel.com>
> Tested-by: Scott Bauer <scott.bauer at intel.com>
> Signed-off-by: Keith Busch <keith.busch at intel.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>

should this get a Cc to stable?



More information about the Linux-nvme mailing list