[PATCH v1] nvmet-rdma: don't forget to delete a queue from the list of connection failed

Sagi Grimberg sagi at grimberg.me
Sun Nov 6 13:33:44 PST 2016


>> In case we accepted a queue connection and it failed, we might not
>> remove the queue from the list until we unload and clean it up.
>> We should delete it from the queue list on the relevant handler.
>
> I think for this to work we'll also need to initialize
> ->queue_list when allocating the queue.

Not really because we'll only manipulate the queue_list if we accept
which means that it's in the list, nvmet_rdma_queue_connect() failures
won't ever see nvmet_rdma_queue_connect_fail(). But I can add it for
good measures...



More information about the Linux-nvme mailing list