[PATCH] nvmet: Don't queue fatal error work if csts.cfs is set

[J Freyensee]

On Fri, 2016-11-04 at 01:01 +0100, Christoph Hellwig wrote:
> > 
> >  {
> > -	ctrl->csts |= NVME_CSTS_CFS;
> > +	if (test_and_set_bit(NVME_CSTS_CFS, (unsigned long
> > *)&ctrl->csts))
> > +		return;
> > +
> 
> This can't work - test_and_set_bit takes a bit index and
> NVME_CSTS_CFS
> is the actual value.  I think we'll need a lock to protect ->csts
> instead.

Yeah, I agree, it feels more like a lock solution.

> 
> 
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme