[PATCH] NVMe: Sync reset and scan work

Keith Busch keith.busch at intel.com
Tue May 24 08:02:55 PDT 2016


On Tue, May 24, 2016 at 08:49:01AM -0600, Keith Busch wrote:
>  	spin_lock_irq(&ctrl->lock);
>  	switch (new_state) {
> +	case NVME_CTRL_SCHED_RESET:
> +		switch (old_state) {
> +		case NVME_CTRL_LIVE:
> +			changed = true;
> +			/* FALLTHRU */
> +		default:
> +			break;
> +		}

Uh, the new state needs to be added as changeable from the old state
going to NVME_CTRL_RESETTING. It's important to test the same code as the
emailed patch, and that would have been obvious nothing was happening...



More information about the Linux-nvme mailing list