[PATCH] NVMe: Recognize the MacBook9,1 NVMe controller
Christoph Hellwig
hch at infradead.org
Mon May 23 04:00:03 PDT 2016
> * some MacBook7,1 to avoid controller resets and data loss.
> + * For the controller found in the MacBook9,1 (device ID 0x2003), it
> + * seems that this workaround is not necessary.
No need for this comment.
> if (pdev->vendor == PCI_VENDOR_ID_APPLE && pdev->device == 0x2001) {
> dev->q_depth = 2;
> @@ -2181,6 +2183,7 @@ static const struct pci_device_id nvme_id_table[] = {
> .driver_data = NVME_QUIRK_IDENTIFY_CNS, },
> { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
> + { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) }, /* for the MacBook 9,1 */
But it might be worth to have a comment above these two entries like
/*
* Controller that don't use the NVMe class code:
*/
and skip the comment after your newly added entry.
Otherwise this looks fine:
Reviewed-by: Christoph Hellwig <hch at lst.de>
More information about the Linux-nvme
mailing list