[PATCHv2] nvme: Make CMB module parameter read-only
Jon Derrick
jonathan.derrick at intel.com
Mon May 2 08:54:02 PDT 2016
This patch changes the use_cmb_sqes module parameter to read-only. This
parameter allows the driver to place IO submission queues within the
Controller Memory Buffer. The parameter is currently writable through
sysfs at /sys/module/nvme/parameters/use_cmb_sqes.
Memory allocations for queues aren't dynamically reallocated between
resets. For this reason, allowing the use_cmb_sqes module parameter to
be written while the drive is loaded may be confusing because we have no
mechanism to dynamically remap the queues.
Signed-off-by: Jon Derrick <jonathan.derrick at intel.com>
---
v2: More thorough log message
drivers/nvme/host/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 4fd733f..83de5569 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -61,7 +61,7 @@ static int use_threaded_interrupts;
module_param(use_threaded_interrupts, int, 0);
static bool use_cmb_sqes = true;
-module_param(use_cmb_sqes, bool, 0644);
+module_param(use_cmb_sqes, bool, 0444);
MODULE_PARM_DESC(use_cmb_sqes, "use controller's memory buffer for I/O SQes");
static struct workqueue_struct *nvme_workq;
--
1.8.3.1
More information about the Linux-nvme
mailing list