[PATCH] nvme-cli: user-defined hostnqn option for discover

J Freyensee james_p_freyensee at linux.intel.com
Thu Jul 28 14:21:54 PDT 2016


On Thu, 2016-07-28 at 16:35 -0400, Keith Busch wrote:
> On Thu, Jul 28, 2016 at 11:20:15PM +0300, Roy Shterman wrote:
> > Hi Jay,
> > 
> > Actually I planned to send the same patch tomorrow,
> > 
> > I think we should add user-defined hostnqn parameter into 'connect'
> > command.
> 
> Is it okay to apply this as-is, or should I wait for the patch for
> connect?

I think we should break up the patches as one for discover, and one for
connect.  Each patch can show a usage for each of the commands (one for
'discover', one for 'connect'.

How about apply my discover patch as-is, then Roy re-submit his patch
for connect?  And in the connect patch, supply an example usage (which
I think this will be useful as there is currently no man pages for
these new fabrics commands).


> 
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme



More information about the Linux-nvme mailing list