[PATCHv3 for-4.7] nvme: Remove RCU namespace protection

Jens Axboe axboe at kernel.dk
Wed Jul 13 09:41:25 PDT 2016


On 07/13/2016 09:48 AM, Keith Busch wrote:
> On Wed, Jul 13, 2016 at 09:24:33AM -0700, Jens Axboe wrote:
>> On 07/12/2016 07:22 PM, Christoph Hellwig wrote:
>>> On Tue, Jul 12, 2016 at 04:15:13PM -0700, Jens Axboe wrote:
>>>> I'm going back and forth on this... This isn't a regression for 4.7, is it?
>>>> If so, I'd be a lot more comfortable queuing this up for 4.8 (marked stable)
>>>> instead. It'll be another late addition, causing issues when it comes time
>>>> to merge for-4.8/drivers in the next merge window.
>>>
>>> It's a 4.7 regression.
>>
>> Two questions, then:
>>
>> 1) Why isn't it marked as such? Should have a Fixes tag.
>
> Sorry, my fault. I missed appending the "fixes" in later revisions as
> this evovled. Should have:
>
>    Reported-by: Ming Lin <mlin at kernel.org>
>    [fixes 0bf77e9 nvme: switch to RCU freeing the namespace]
>
>> 2) It's so large... Not really a question, other than, how can we make it
>> smaller/more contained?
>
> Fair enough. Part of the changes are not absolutely necessary (the
> ordered insertion, for example). I'll resend a smaller patch with
> the appropriate tags.

Thanks, please do. The smaller, the better...

-- 
Jens Axboe




More information about the Linux-nvme mailing list