[PATCH] nvme-rdma: Always signal fabrics private commands

[Sagi Grimberg]

> Double completion?  When the QP exits RTS with pending unsignaled SQ WRs, cxgb4
> doesn't know if those were actually completed by hardware, so they are completed
> with FLUSH_ERR status.  I _could_ change cxgb4 to just eat those, but I'm a
> little worried about breaking the iWARP Verbs semantics.  Perhaps I shouldn't
> be.  It does seem to be causing lots of pain...

What exactly breaks iWARP semantics here?

Think of a case where we posted unsignaled send, got a successful reply
from the peer, now we drain the qp, and the send which belongs to a
transaction that we already completed is flush with error. Does that
sound like a correct behavior?