[PATCHv3 for-4.7] nvme: Remove RCU namespace protection

Jens Axboe axboe at kernel.dk
Tue Jul 12 16:15:13 PDT 2016


On 07/08/2016 06:07 PM, Keith Busch wrote:
> On Wed, Jul 06, 2016 at 11:22:50AM -0600, Keith Busch wrote:
>> We can't block with RCU read lock held, but we need to do potentially
>> blocking stuff to namespace queues when iterating the list. This patch
>> removes the rcu read locking.
>>
>> Any list iteration that does IO has to be done unlocked to allow recovery.
>> The caller must ensure the list can not be manipulated under such
>> conditions. List iterations that do not issue IO can safely use the lock
>> since it wouldn't block recovery from missing IO completions.
>
> Ping? Would hate to release a kernel with obvious bugs.

I'm going back and forth on this... This isn't a regression for 4.7, is 
it? If so, I'd be a lot more comfortable queuing this up for 4.8 (marked 
stable) instead. It'll be another late addition, causing issues when it 
comes time to merge for-4.8/drivers in the next merge window.

-- 
Jens Axboe




More information about the Linux-nvme mailing list