[PATCH 1/2] NVMe: Make surprise removal work again

Keith Busch keith.busch at intel.com
Thu Jan 28 06:55:50 PST 2016


On Thu, Jan 28, 2016 at 04:48:16PM +0200, Sagi Grimberg wrote:
> >That works only for active requests. There could be processes that entered
> >the queue and waiting for request tags to become available. These need
> >to be flushed to completion somehow ... maybe they shouldn't even succeed
> >in getting a request on a dying queue?
> 
> Isn't that what blk_mq_wake_waiters() is for?

Yes, that'll wake processes waiting on tags, but not to their
demise. They'll get a tag and send it to the h/w context. We need to
start these back up so the driver can end those requests, or we need to
do something to end them at the block layer. It sounds like developers
are preferring the latter.



More information about the Linux-nvme mailing list