[PATCH 5/5] NVMe: IO queue deletion re-write

Keith Busch keith.busch at intel.com
Sat Jan 2 13:30:09 PST 2016


On Sat, Jan 02, 2016 at 09:07:30AM -0800, Christoph Hellwig wrote:
> Just curious:  why do we even both with the async queue shutdown.  At
> least the controllers I have access to complete queue deletions very
> quickly.

The async deletion was written for a bug reporting "hang" on a device
removal. The "hang" was the controller taking on the order of 100's msec
to delete a queue (sometimes >1sec if lots of commands queued). This
controller had 2k queues, and took ~15 minutes to remove serially. Async
deletion brought it down to ~20 seconds, so looked like a good idea.

It wasn't a controller I make, so I personally don't care about
parallelizing queue deletion. The driver's been this way for so long
though, I don't have a good way to know how beneficial this feature
is anymore.



More information about the Linux-nvme mailing list