[PATCH 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features()

Keith Busch keith.busch at intel.com
Mon Aug 29 09:27:35 PDT 2016


On Mon, Aug 29, 2016 at 02:25:45AM -0700, Andy Lutomirski wrote:
> +	/*
> +	 * A controller "page" may be bigger than a Linux page, but we can
> +	 * be conservative here.
> +	 */

It is the actually other way around: the Linux page may be larger than the
controller's. We currently use the smallest possible controller page (4k)
regardless of the host's size due to limitations discovering the CPU's
DMA alignment. PPC was the first to encounter this problem with NVMe.

Otherwise, looks good.



More information about the Linux-nvme mailing list