[PATCH] nvme-cli/fabrics: Add nr_io_queues parameter to connect command

J Freyensee james_p_freyensee at linux.intel.com
Mon Aug 29 08:14:31 PDT 2016


On Mon, 2016-08-29 at 10:05 -0500, Steve Wise wrote:
> > 
> > > 
> > > On Sun, Aug 28, 2016 at 09:11:42PM -0700, J Freyensee wrote:
> > > > 
> > > > On Fri, 2016-08-26 at 08:56 -0700, Steve Wise wrote:
> > > > > 
> > > > > Added 'nr_io_queues' to 'connect' command so users can
> > > > > specify the
> > > > > number
> > > > > of io queues to allocate.
> > > > > 
> > > > > usage example:
> > > > > 
> > > > > nvme connect -t rdma -Q 8 -s 4420 -a 10.0.1.14 -n test-nvme
> > > > 
> > > > I was just wondering if there could be another lower-case
> > > > letter flag
> > > > option we could use other than capital Q. ??Just looking at the
> > > > example
> > > > above, it looks a tad out-of-place.
> > > 
> > > -q would be nice. For that'd we need to rename the hostnqn one,
> > > but as
> > > stated before I think -q is really misnamed for that anyway..
> > 
> > -h for hostnqn?
> 
> Oops... -h is 'help' :)

Yep, all the good single letter flags are being taken ;-P.

-i seems fine to me.  I kind of like -q for hostnqn since hostnqn does
have a 'q' in it so there is somewhat of a mind-remembrance game there
:-).

> 
> 
> 



More information about the Linux-nvme mailing list