[PATCH 4/5] nvme-fabrics: Add target FC transport support

James Smart james.smart at broadcom.com
Mon Aug 22 10:28:39 PDT 2016



On 8/11/2016 2:22 PM, Christoph Hellwig wrote:
>
>> +	queue->work_q = alloc_workqueue("ntfc%d.%d.%d", 0, 0,
>> +				assoc->tgtport->fc_target_port.port_num,
>> +				assoc->a_id, qid);
> Do we really need a workqueue per queue?

I thought we did - so there was always an execution context for the 
nvmet layer when a command is received. My understanding was the nvmet 
layer processes the cmd synchronously. I avoided per cpu - as I assumed 
the synchronous flows would end up blocking other connections to other 
subsystems/controllers.

If that's not the case - can you describe the nvmet layer better so I 
understand what we need ?


>
> No reference counting?
>

yes - will make a pass at it.

-- james




More information about the Linux-nvme mailing list