[PATCH v1 3/5] nvmet-rdma: +1 to *queue_size from hsqsize/hrqsize

Verkamp, Daniel daniel.verkamp at intel.com
Mon Aug 15 08:54:05 PDT 2016


On Fri, 2016-08-12 at 17:04 -0700, Jay Freyensee wrote:
> Now that the host will be sending sqsize 0-based values,
> the target need to be adjusted as well.
> 
> Signed-off-by: Jay Freyensee <james_p_freyensee at linux.intel.com>
> ---
>  drivers/nvme/target/rdma.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
> index e06d504..d7cb98d 100644
> --- a/drivers/nvme/target/rdma.c
> +++ b/drivers/nvme/target/rdma.c
> @@ -1004,11 +1004,11 @@ nvmet_rdma_parse_cm_connect_req(struct
> rdma_conn_param *conn,
>  	queue->host_qid = le16_to_cpu(req->qid);
>  
>  	/*
> -	 * req->hsqsize corresponds to our recv queue size
> -	 * req->hrqsize corresponds to our send queue size
> +	 * req->hsqsize corresponds to our recv queue size plus 1
> +	 * req->hrqsize corresponds to our send queue size plus 1
>  	 */
> -	queue->recv_queue_size = le16_to_cpu(req->hsqsize);
> -	queue->send_queue_size = le16_to_cpu(req->hrqsize);
> +	queue->recv_queue_size = le16_to_cpu(req->hsqsize + 1);
> +	queue->send_queue_size = le16_to_cpu(req->hrqsize + 1);

I think the + 1 needs to be outside le16_to_cpu() here so the math is
done in the native CPU byte order.

-- Daniel


More information about the Linux-nvme mailing list