[PATCH RFC 1/4] fabrics: define admin sqsize min default, per spec

Christoph Hellwig hch at lst.de
Thu Aug 11 08:08:46 PDT 2016


On Thu, Aug 11, 2016 at 12:01:59PM +0300, Sagi Grimberg wrote:
> it with the non-default value. I honestly don't see the reason
> to keep it in a variable when no one is making real use
> of it.
>
> If you would have exposed it to user-space then it would make
> better sense (although I'm not a fan of adding not very useful
> configs to user-space).

I agree - until we have a good use case for large admin queues
we should keep things simple.  And I'm still pissed about the idiotic
addition of the admin queue size to the discovery records in the last
moment.  It's entirely contrary to the disccovery service abstraction
we build, and pointless as well.  So the more we can ignore it, the
better.



More information about the Linux-nvme mailing list