[PATCH RFC] nvmet-rdma: +1 to *queue_size from hsqsize/hrqsize

J Freyensee james_p_freyensee at linux.intel.com
Mon Aug 8 10:48:17 PDT 2016


On Mon, 2016-08-08 at 16:09 +0000, Verkamp, Daniel wrote:
> Hi Jay,
> 
> On Fri, 2016-08-05 at 20:00 -0700, Jay Freyensee wrote:
> > 
> > -	queue->recv_queue_size = le16_to_cpu(req->hsqsize);
> > -	queue->send_queue_size = le16_to_cpu(req->hrqsize);
> > +	queue->recv_queue_size = le16_to_cpu(req->hsqsize)+1;
> > +	queue->send_queue_size = le16_to_cpu(req->hrqsize)+1;
> 
> I think the +1 needs to be inside the le16_to_cpu() in both cases.

Thanks.

This patch will be dependent on the "nvme-rdma: sqsize/hsqsize/hrqsize
is 0-based val" patch, which reading the spec again I still think it's
0-based.

> 
> -- Daniel



More information about the Linux-nvme mailing list