[PATCH 2/2] nvme-rdma: sqsize/hsqsize/hrqsize is 0-based val

Christoph Hellwig hch at lst.de
Mon Aug 8 00:06:20 PDT 2016


On Sun, Aug 07, 2016 at 10:29:08AM +0300, Sagi Grimberg wrote:
> Did we really decide that? The spec actually explicitly says
> that a 0 sqsize will be failed:
>
> "If the size is 0h or larger than the controller supports, then a
> status value of Connect Invalid Parameters shall be returned."
>
> And then it says: "This is a 0’s based value"
>
> Confusing....

Yeah, I think we'll need an errate in the TWG.  And I think the
current Linux behavior is the sensible one.  Jay, do you want
to drive this in the WG or I should I bring it up?



More information about the Linux-nvme mailing list